Make direct buffer allocation optional #39
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor refactoring of all codecs that directly allocate Java
ByteBuffers
: instead of making a direct call toByteBuffer#allocate()
, the codec invokes a protected methodmakeBuffer(size)
. This allows a user to subclass the codec and override the method to customize the buffer allocation.In particular, this enables users to use heap-buffers and/or buffer pooling. The latter is essential for reducing memory churn.
In a JVM benchmark (not included) on some real-world data, this refactoring did not decrease performance. (Notice that dropping
final
from some classes does not stop the JVM from inlining, such as in monomorphic callsites.)